Lighting is most important for good pictures. You have to decide whether your glass looks better in fluorescent, incandescent, or natural light. I haven't photographed but one carnival piece, so I don't know which is best. Your marigold or blue carnivals do best on a white background. White glass photographs better on dark blue or black. Unless it is a huge piece, use the macro setting (flower image). I simply point, focus, & shoot. I take several digital photos of each position, then save only the best one on the computer.
The next step is to take your picture to a good OCR program. I use PhotoDraw -- an old Microsoft product. Others use PhotoShop. There are many others that are pretty good. Some packages are free downloads. I only do four things with the OCR program if needed -- crop, adjust white balance, sharpen, and add a touch of contrast. The last thing (contrast) I do very conservatively, because it can change the appearance of the glass completely. (I usually end up doing one more thing -- cloning to get the stray rabbit hair off the background. I never see them until I'm processing pictures.)
Taking good glass pictures is not difficult if you can get the lighting right and know how to do the final processing steps.